Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: discussion handler #51

Merged
merged 3 commits into from
Jan 17, 2024
Merged

feat: discussion handler #51

merged 3 commits into from
Jan 17, 2024

Conversation

elianiva
Copy link
Member

@elianiva elianiva commented Jan 14, 2024

closes #41
should add more tests buat handler lain, tapi nanti aja PR terpisah

@elianiva elianiva self-assigned this Jan 14, 2024
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 166 lines in your changes are missing coverage. Please review.

Comparison is base (7d30de6) 96.38% compared to head (ed8c73c) 26.14%.

Files Patch % Lines
src/application/webhook/types/Entity.ts 0.00% 40 Missing ⚠️
src/application/webhook/types/Webhook.ts 0.00% 33 Missing and 1 partial ⚠️
src/application/webhook/types/Events.ts 0.00% 31 Missing and 1 partial ⚠️
src/application/webhook/types/Actions.ts 0.00% 26 Missing and 1 partial ⚠️
.../application/interfaces/events/IDiscussionEvent.ts 0.00% 11 Missing and 1 partial ⚠️
src/presentation/routes/GithubRoute.ts 0.00% 9 Missing ⚠️
src/index.ts 0.00% 4 Missing ⚠️
src/application/App.ts 0.00% 3 Missing ⚠️
src/presentation/TelegramPresenter.ts 0.00% 3 Missing ⚠️
src/application/interfaces/events/index.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master      #51       +/-   ##
===========================================
- Coverage   96.38%   26.14%   -70.24%     
===========================================
  Files           3       46       +43     
  Lines         166     2176     +2010     
  Branches       34       85       +51     
===========================================
+ Hits          160      569      +409     
- Misses          6     1576     +1570     
- Partials        0       31       +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elianiva elianiva requested a review from aldy505 January 17, 2024 02:00
@aldy505 aldy505 merged commit cabc3a3 into master Jan 17, 2024
3 of 5 checks passed
@aldy505 aldy505 deleted the feat/discussion-handler branch January 17, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discussion notification support
2 participants